Skip to content

Add support for file inputs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2020
Merged

Add support for file inputs #4

merged 5 commits into from
Feb 7, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented Feb 6, 2020 •
edited
Loading

Fixes #2.

This adds support for <input type="file">, associating to <file-attachment> via an input attribute.

<file-attachment input="upload">
  <input type="file" id="upload" multiple>
</file-attachment>

I opted to name the attribute input instead of for to avoid confusion with <label for>. In the case of <label for>, input is implicitly associated through nesting, which isn't the true here.

@muan muan marked this pull request as ready for review February 7, 2020 21:09
@muan muan requested review from a team, clayplumridge and dgraham and removed request for clayplumridge February 7, 2020 21:09
@muan muan changed the base branch from tests to master February 7, 2020 21:11
dgraham
dgraham approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@dgraham dgraham merged commit 5b69b93 into master Feb 7, 2020
@dgraham dgraham deleted the input branch February 7, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dgraham dgraham dgraham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling file input
2 participants
@muan @dgraham