Skip to content

<filter-input> #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 27, 2019
Merged

<filter-input> #1

merged 9 commits into from
Nov 27, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Nov 25, 2019 •
edited
Loading

This extracts <filter-input>, with these changes:

  • A switch from Flow to Typescript
  • New tests
  • New readme
  • New demo page

Once this is merged I will bump the version to 0.1.0 and release.

@muan muan marked this pull request as ready for review November 26, 2019 21:58
@muan muan requested a review from a team November 26, 2019 21:58
keithamus
keithamus approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Clear and concise README, wonderful!

dgraham
dgraham approved these changes Nov 27, 2019
View reviewed changes
@muan muan merged commit 2b287c9 into master Nov 27, 2019
@muan muan deleted the init branch November 27, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@keithamus keithamus keithamus approved these changes

@dgraham dgraham dgraham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muan @keithamus @dgraham