Skip to content

Add skin tones support #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Add skin tones support #165

merged 4 commits into from
Nov 15, 2022

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Jul 3, 2019

This adds:

  • Emoji::Character#skin_tones? - inspect support for Fitzpatrick skin tone modifiers (1F3FB-1F3FF).
  • Emoji::Character#raw_skin_tone_variants - generate all skin tone variants for an emoji.
  • Emoji.find_by_unicode now recognizes unicode sequences with a skin tone modifier.

@chvp
Copy link
Contributor

chvp commented Jan 30, 2020

Any reason this isn't merged?

@kinduff
Copy link

kinduff commented Oct 26, 2021

👍 on this, hope this can get attention and get merged

@parkr parkr mentioned this pull request Oct 30, 2021
- Lookup emoji by unicode that contains a skin tone modifier
- Generate skin tone variants from an emoji
@mislav
Copy link
Contributor Author

mislav commented Nov 15, 2022

@chvp Sorry for my late reply. This reason this wasn't merged is because emoji.skin_tones? on its own wasn't very useful to ship. Your application would be able to detect if an emoji supported skin tones, but not much more unless you built up the logic of parsing/inserting the Fitzpatrick modifiers yourself.

I've now added support for skin tones to Emoji.find_by_unicode and the ability to list each skin tone variant for an emoji: Emoji::Character#raw_skin_tone_variants.

@mislav mislav merged commit 70eb18c into master Nov 15, 2022
@mislav mislav deleted the skin-tones branch November 15, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants