-
Notifications
You must be signed in to change notification settings - Fork 1k
Support assigning copilot to issues #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support assigning copilot to issues #418
Conversation
b9f493e
to
b4da208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for assigning the Copilot bot to GitHub issues via a new tool and covers it with an end-to-end test.
- Registers a new
assign_copilot_to_issue
tool in the server’s toolset - Implements the GraphQL logic to find and assign the Copilot bot
- Extends E2E tests with
TestAssignCopilotToIssue
and related assertion fixes
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
pkg/github/tools.go | Adds AssignCopilotToIssue to the initialized toolset |
pkg/github/issues.go | Implements the GraphQL-based assignment logic |
internal/githubv4mock/*.go | Adds typed-nil equality support in mock equality helpers and tests |
e2e/e2e_test.go | Introduces the end-to-end test for assigning Copilot to issues |
Comments suppressed due to low confidence (2)
pkg/github/issues.go:11
- The handler in
AssignCopilotToIssue
usescontext.Context
andfmt
but neither package is imported; addimport "context"
andimport "fmt"
to avoid compile errors.
import (
e2e/e2e_test.go:990
- The assertion message refers to
'get_me'
but this call is forcreate_repository
; update the message to reflect the correct tool name.
require.NoError(t, err, "expected to call 'get_me' tool successfully")
b4da208
to
4ea2a1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love @mntlty's suggestion of the docs link. Some agents might even follow it and tell the user what to do themselves. Or just do it themselves and become the event that caused the singularity.
Other than the two suggestions I think this is awesome.
4ea2a1a
to
da11920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it a lot, one comment about the placement of the links, and whether that work as I hope or if it fails to help the user fix the issue because it doesn't suggest the link. LMK :-D
Co-authored-by: Martina Jireckova <martinajir@github.com>
da11920
to
361bab9
Compare
Description
Closes: #398
This adds a new tool
assign_copilot_to_issue
, which...assigns copilot to an issue.Since the coding agent is in public preview, it can require configuring manually. Thus, the e2e test will skip if it gets an error that copilot could not be found as a reviewer.