Skip to content

Fix role from "system" to "user" in message prompt #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Conversation

tommaso-moro
Copy link
Contributor

@tommaso-moro tommaso-moro commented Aug 21, 2025

Closes: #887

The system prompt is not valid according to the MCP specs, so we use user instead

0xGosu and others added 2 commits August 16, 2025 16:33
…ingAgentPrompt` and `IssueToFixWorkflowPrompt`. Role "system" is not allowed by Claude Code in MCP provided prompt (allowed only role "user" and "assistant")
@tommaso-moro tommaso-moro requested a review from a team as a code owner August 21, 2025 14:42
@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 14:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the role configuration for two MCP prompt messages by changing them from "system" to "user" role, addressing issue #887.

  • Changes the role from "system" to "user" for workflow and coding agent prompt messages
  • Updates two different MCP prompt configurations to ensure proper role assignment

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/github/workflow_prompts.go Changes role from "system" to "user" for the issue workflow prompt message
pkg/github/issues.go Changes role from "system" to "user" for the coding agent assignment prompt message

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tommaso-moro tommaso-moro changed the title Tommy/fix-role Fix role from "system" to "user" in message prompt Aug 21, 2025
Copy link
Contributor

@LuluBeatson LuluBeatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tommaso-moro tommaso-moro merged commit 0418808 into main Aug 21, 2025
16 checks passed
@tommaso-moro tommaso-moro deleted the tommy/fix-role branch August 21, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a valid role for prompts: assistant instead of system
3 participants