Skip to content

fix(types): use correct type expression #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2020
Merged

fix(types): use correct type expression #28

merged 1 commit into from
Feb 28, 2020

Conversation

keithamus
Copy link
Contributor

There was a typo in the .d.ts file. It used string || null which is meant to be string | null

@keithamus keithamus requested a review from a team February 28, 2020 13:41
koddsson
koddsson approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ✨

@keithamus keithamus merged commit 0ae9d41 into master Feb 28, 2020
@keithamus keithamus deleted the fix-types-use-correct-type-expression branch February 28, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithamus @koddsson