Skip to content

TypeScript conversion #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2020
Merged

TypeScript conversion #29

merged 5 commits into from
May 21, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented May 20, 2020 •
edited
Loading

  • TypeScript
  • Remove UMD build
  • Update test to run on multiple OSes
  • Upgrade dependencies
  • Travis CI -> GitHub Actions
  • Remove network requirement from test
    • The test was consistently failing on windows-latest at loading the remote image. I changed it to a data URL string, and the test passes. I'm not sure why loading the remote image fails on Windows, but I think it's good to not rely on a remote in our tests regardless. I've also manually tested the code in browserstack on Windows and ensured it does work in the example.

@muan muan force-pushed the ts branch 2 times, most recently from 23db8aa to 2a81e4d Compare May 20, 2020 20:51
@muan muan changed the title Ts TypeScript conversion May 20, 2020
@muan muan force-pushed the ts branch 2 times, most recently from bbe8c10 to 595dd99 Compare May 20, 2020 21:02
@muan muan marked this pull request as ready for review May 20, 2020 21:10
@muan muan requested a review from a team May 20, 2020 21:18
koddsson
koddsson approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muan muan merged commit 48535c6 into master May 21, 2020
@muan muan deleted the ts branch May 21, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muan @koddsson