Skip to content

Fix visible edge of crop area on wider images #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

Fix visible edge of crop area on wider images #36

merged 1 commit into from
Mar 15, 2021

Conversation

simonw
Copy link
Contributor

@simonw simonw commented Mar 12, 2021

I picked 4000px here because that feels like a high enough value here that the component is unlikely to be used on a page where the crop area is larger than this.

Closes #35

@simonw simonw requested a review from a team as a code owner March 12, 2021 19:12
@simonw simonw requested review from T-Hugs and srt32 March 12, 2021 19:12
koddsson
koddsson approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🏻

@koddsson koddsson merged commit 6161405 into github:main Mar 15, 2021
@koddsson
Copy link
Contributor

Published in https://github.com/github/image-crop-element/releases/tag/v4.1.1

@simonw simonw deleted the patch-1 branch March 19, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

@T-Hugs T-Hugs Awaiting requested review from T-Hugs

@srt32 srt32 Awaiting requested review from srt32

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's possible to see the edges of the shaded crop-outline area
2 participants
@simonw @koddsson