Skip to content

Check if there's a network request already in flight #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2022
Merged

Check if there's a network request already in flight #79

merged 2 commits into from
Mar 31, 2022

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Mar 30, 2022 •
edited
Loading

Make sure not to fire off additional requests if there's already one in-flight. I chose to reflect this on the element through the read-only busy attribute.

Fixes #75

@koddsson koddsson marked this pull request as ready for review March 30, 2022 15:03
@koddsson koddsson requested a review from a team as a code owner March 30, 2022 15:03
@koddsson koddsson requested a review from manuelpuyol March 30, 2022 15:03
@koddsson
Copy link
Contributor Author

This probably needs a failing test before the fix commit.

Base automatically changed from refactor to main March 30, 2022 15:55
keithamus
keithamus approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Is it instead better to use AbortControllers to close previous requests, so that we always use the latest request?

@koddsson
Copy link
Contributor Author

Seems reasonable. Is it instead better to use AbortControllers to close previous requests, so that we always use the latest request?

Yeah, I think we could. I wanted to avoid doing multiple requests altogether though since I thought that was an error in itself.

@koddsson
Copy link
Contributor Author

koddsson commented Mar 31, 2022 •
edited
Loading

Seems reasonable. Is it instead better to use AbortControllers to close previous requests, so that we always use the latest request?

Yeah, I think we could. I wanted to avoid doing multiple requests altogether though since I thought that was an error in itself.

I was gonna do this but then we still emit the event twice because #getData still fetches data from the WeakMap and we happily emit the event.

I think we can refactor more in this component to make something like that easier but that would probably result in a breaking change.

@koddsson koddsson merged commit c405e3a into main Mar 31, 2022
@koddsson koddsson deleted the check-if-network-request-is-already-in-flight branch March 31, 2022 14:55
@dgreif dgreif mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@manuelpuyol manuelpuyol Awaiting requested review from manuelpuyol manuelpuyol was automatically assigned from github/web-systems-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include-fragment-replaced triggered twice
2 participants
@koddsson @keithamus