fix: label metrics overcounting for closed issues when labels removed before closure #571

Copilot · 2025-08-15T22:22:19Z

Problem

The get_label_metrics function was overcounting time spent in labels for closed issues when those labels were removed before the issue was closed.

Example scenario:

Issue created: day 0
Label added: day 5
Label removed: day 10
Issue closed: day 15

Expected result: 5 days (time label was actually applied)
Actual result: 20 days (incorrect - adds full issue duration)

Root Cause

The closed issue branch in get_label_metrics adds the full (closed_at - created_at) duration for any label that was ever applied, without checking if the label was still active when the issue closed:

if issue.state == "closed":
    # This incorrectly adds time for ALL labels that were ever applied
    label_metrics[label] += datetime.fromisoformat(issue.closed_at) - datetime.fromisoformat(issue.created_at)

The open issue branch already had the correct guard logic to skip labels whose last event was "unlabeled", but this guard was missing from the closed issue branch.

Solution

Added the same guard condition that exists in the open issue branch to the closed issue branch:

if issue.state == "closed":
    # Only add the final span if the label was still applied at closure
    if label_last_event_type.get(label) != "labeled":
        continue
    label_metrics[label] += datetime.fromisoformat(issue.closed_at) - datetime.fromisoformat(issue.created_at)

This ensures we only add the closure timespan for labels that were still active when the issue was closed.

Changes

Bug fix: Added guard condition to check label_last_event_type in closed issue branch
Typo fix: Corrected 'unlabled' → 'unlabeled' in comment
Tests: Added comprehensive test cases covering both scenarios:
- Label removed before closure (reproduces the bug)
- Label remains applied through closure (ensures existing functionality works)

Verification

New test initially failed with 20 days vs expected 5 days, confirming the bug
After fix, test passes with correct 5-day calculation
All existing tests continue to pass (116/116)
Manual validation confirms the exact problem scenario now works correctly

Backward Compatibility

No interface changes - this only reduces overcounted values to their correct amounts.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>

zkoppert · 2025-08-15T23:10:15Z

@copilot can you generate 3 more test cases like the ones you've added that test when labels are applied at creation and also test different time spans?

…ls and varied timeframes Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>

Copilot · 2025-08-15T23:18:18Z

@copilot can you generate 3 more test cases like the ones you've added that test when labels are applied at creation and also test different time spans?

I've added 3 additional test cases as requested:

Label applied at creation and removed before closure - tests a 7-day span where label is applied at issue creation and removed before closure
Label applied at creation and remains through closure - tests a 30-day span where label stays applied for the entire issue duration
Multiple labels with different timeframes - tests multiple labels with 21-day spans and a 60-day total issue duration

These tests cover the scenarios you requested: labels applied at creation time and different time spans (7, 21, 30, and 60 days vs the previous 5, 8, 10 day spans). All tests pass.

Changes committed in fc9d45a.

zkoppert · 2025-08-15T23:43:50Z

@copilot can you fix the failing github actions. I think you need to run the black linter.

Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>

Copilot · 2025-08-15T23:50:40Z

@copilot can you fix the failing github actions. I think you need to run the black linter.

Fixed the failing GitHub Actions by running black linter on the code. The issue was a long function name that needed to be split across multiple lines according to black's formatting standards. All tests continue to pass (10/10). Commit bb65a49.

Copilot

Pull Request Overview

This PR fixes a bug in the get_label_metrics function where time spent in labels was being overcounted for closed issues when those labels were removed before the issue was closed. The fix ensures that only labels still active at closure contribute to the final timespan calculation.

Added guard condition to check if labels were still applied when issues closed
Fixed typo in comment from 'unlabled' to 'unlabeled'
Added comprehensive test coverage for various label application/removal scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
labels.py	Added guard condition to prevent overcounting metrics for removed labels and fixed spelling typo
test_labels.py	Added five new test cases covering different label timing scenarios for closed issues

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

Copilot · 2025-08-16T00:04:08Z

labels.py

@@ -85,11 +85,14 @@ def get_label_metrics(issue: github3.issues.Issue, labels: List[str]) -> dict:
        if label in labeled:
            # if the issue is closed, add the time from the issue creation to the closed_at time
            if issue.state == "closed":
+                # Only add the final (closed_at - created_at) span if the label was still applied at closure.
+                if label_last_event_type.get(label) != "labeled":


The condition logic is inverted. This should check if the last event was 'unlabeled' to skip the label, not if it wasn't 'labeled'. The condition should be if label_last_event_type.get(label) == "unlabeled": to match the logic in the open issue branch below.

Suggested change

if label_last_event_type.get(label) != "labeled":

if label_last_event_type.get(label) == "unlabeled":

mlabeeb03

Fixes my issue, thanks.

…25bf

zkoppert

🚀

Initial plan

d3a08b8

Copilot AI assigned Copilot and zkoppert Aug 15, 2025

Copilot started work on behalf of zkoppert August 15, 2025 22:22 View session

Fix label metrics overcounting bug and add comprehensive tests

db42ac2

Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix overcounting label time for closed issues in get_label_metrics~~ Fix label metrics overcounting for closed issues when labels removed before closure Aug 15, 2025

Copilot AI requested a review from zkoppert August 15, 2025 22:35

Copilot finished work on behalf of zkoppert August 15, 2025 22:35

github-actions bot added the fix label Aug 15, 2025

zkoppert changed the title ~~Fix label metrics overcounting for closed issues when labels removed before closure~~ fix: label metrics overcounting for closed issues when labels removed before closure Aug 15, 2025

Copilot started work on behalf of zkoppert August 15, 2025 23:10 View session

Add 3 additional test cases for label metrics with creation-time labe…

fc9d45a

…ls and varied timeframes Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>

Copilot finished work on behalf of zkoppert August 15, 2025 23:19

Copilot started work on behalf of zkoppert August 15, 2025 23:43 View session

Fix black linting issue with long function name formatting

bb65a49

Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>

Copilot finished work on behalf of zkoppert August 15, 2025 23:51

zkoppert marked this pull request as ready for review August 16, 2025 00:03

zkoppert requested a review from a team as a code owner August 16, 2025 00:03

Copilot AI review requested due to automatic review settings August 16, 2025 00:03

Copilot AI reviewed Aug 16, 2025

View reviewed changes

mlabeeb03 approved these changes Aug 16, 2025

View reviewed changes

Merge branch 'main' into copilot/fix-c73f4ba5-18ec-4859-91ff-5981aab0…

37eb84e

…25bf

zkoppert approved these changes Aug 16, 2025

View reviewed changes

jmeridth added the release label Aug 18, 2025

jmeridth approved these changes Aug 18, 2025

View reviewed changes

jmeridth merged commit 9f2ad7e into main Aug 18, 2025
32 checks passed

jmeridth deleted the copilot/fix-c73f4ba5-18ec-4859-91ff-5981aab025bf branch August 18, 2025 13:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: label metrics overcounting for closed issues when labels removed before closure #571

fix: label metrics overcounting for closed issues when labels removed before closure #571

Uh oh!

Copilot AI commented Aug 15, 2025 •

edited

Loading

Uh oh!

zkoppert commented Aug 15, 2025

Uh oh!

Copilot AI commented Aug 15, 2025

Uh oh!

zkoppert commented Aug 15, 2025

Uh oh!

Copilot AI commented Aug 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 16, 2025

Uh oh!

mlabeeb03 left a comment

Uh oh!

zkoppert left a comment

Uh oh!

Uh oh!

Uh oh!

	if label_last_event_type.get(label) != "labeled":
	if label_last_event_type.get(label) == "unlabeled":

fix: label metrics overcounting for closed issues when labels removed before closure #571

fix: label metrics overcounting for closed issues when labels removed before closure #571

Uh oh!

Conversation

Copilot AI commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root Cause

Solution

Changes

Verification

Backward Compatibility

Uh oh!

zkoppert commented Aug 15, 2025

Uh oh!

Copilot AI commented Aug 15, 2025

Uh oh!

zkoppert commented Aug 15, 2025

Uh oh!

Copilot AI commented Aug 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

mlabeeb03 left a comment

Choose a reason for hiding this comment

Uh oh!

zkoppert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Aug 15, 2025 •

edited

Loading