allow use of <button> elements with `data-md-button="{style}" #72

keithamus · 2023-07-17T16:00:35Z

This allows the use of data-md-button={style}, where style is a specific style like code, header-6, etc.

The intent of this is to allow arbitrary tags like <div> or <button> to be used over the <md-button> variants.

primer-css · 2023-07-17T16:05:46Z

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

jonrohan · 2023-07-17T16:07:23Z

The intent of this is to allow arbitrary tags like <div> or <button> to be used over the <md-button> variants.

Not sure it matters, but not my intent to put on a non-interactive element like <div>.

jonrohan

Thanks for this!

allow use of <button> elements with `data-md-button="{style}"

2c8a329

keithamus requested a review from a team as a code owner July 17, 2023 16:00

jonrohan approved these changes Jul 17, 2023

View reviewed changes

keithamus merged commit ce94934 into main Jul 17, 2023

keithamus deleted the allow-use-of-button-elements-with-data-md-button-style branch July 17, 2023 16:18

Provide feedback