Skip to content

Update Turkish Translation #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
May 3, 2020
Merged

Update Turkish Translation #1600

merged 38 commits into from
May 3, 2020

Conversation

umutphp
Copy link
Contributor

@umutphp umutphp commented May 2, 2020

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Changes done:

  • Update the Turkish translations of the articles
  • Fix Markdown linter bugs
  • Remove the translations of the sections removed from English content

@umutphp umutphp changed the title Update Turkish Translation WIP: Update Turkish Translation May 3, 2020
@umutphp umutphp changed the title WIP: Update Turkish Translation Update Turkish Translation May 3, 2020
@umutphp
Copy link
Contributor Author

umutphp commented May 3, 2020

I have checked the errors in LinkCheck step and the errors thrown. All of the internal links thrown as error are working correctly on the live site and Github interface. I could not find a way to fix them.

@mlinksva
Copy link
Contributor

mlinksva commented May 3, 2020

@umutphp this PR rewraps <aside>s to one line, and as these have mixed HTML and markup, I think the renderer gets horribly confused, resulting in some escaped HTML being output in the asides, and (though I'm not sure why) subsequent internal anchors with non-ascii characters being generated incorrectly. I corrected a few of the asides in 98e963b to get one of the reported broken links to go away. If you fix the rest tests will pass and all of the asides will be rendered correctly (without escaped HTML).

It looks like this came up before in #1112 (comment)

@umutphp
Copy link
Contributor Author

umutphp commented May 3, 2020

Hi @mlinksva,

Many thanks for the feedback :).

I fixed the broken "aside" tags and all the checks passed.

@mlinksva mlinksva merged commit e33676d into github:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants