feat: ensure contents of container image changes #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
jmeridth
commented
Jan 25, 2025
| .git | ||
| .gitattributes | ||
| .gitignore | ||
| .github/ |
There was a problem hiding this comment.
formatting of file, but this was the important change.
I got confused when the release tagging was being applied to the same release package (container image). This was because the container image was not changing. With this change, we put the contents of the repo into the container image, ensuring there is change and a new image and digest is created. This will also cause new attestation to be created. - [x] remove .github folder from .dockerignore to ensure the folder is put into the container image - [x] update README explaining what the image contents are and why Signed-off-by: jmeridth <jmeridth@gmail.com>
634d50f to
5ab77ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got confused when the release tagging was being applied to the same release package (container image). This was because the container image was not changing.
With this change, we put the contents of the repo into the container image, ensuring there is change and a new image and digest is created. This will also cause new attestation to be created.