fix: add secret/token to major-version-updater #57
Conversation
jmeridth
commented
Apr 8, 2025
- add docs
- add link to docs from README
- fix tag name argument from underscore to hyphen
|
We may not be able to do major-version-updater as a reusable workflow due to permissions. When testing I'm getting permissions errors. Trying to solve. |
|
This PR is stale because it has been open 20 days with no activity. Replace the |
|
This PR is stale because it has been open 20 days with no activity. Replace the |
- [x] add docs - [x] add link to docs from README - [x] fix tag name argument from underscore to hyphen - [x] use github token in right places (GITHUB_TOKEN or arg) Signed-off-by: jmeridth <jmeridth@gmail.com>
a903107 to
1e02d9e
Compare
|
Merging so I can test from my testing repo. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a github-token secret in the Major Version Updater workflow, updates documentation, and standardizes the tag-name input.
- Add
github-tokensecret requirement tomajor-version-updater.ymland propagate it through tests and docs - Update README to link the new Major Version Updater documentation
- Rename
tag_nametotag-nameacross relevant workflows
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/major-version-updater.md | Documented github-token secret input |
| README.md | Added link to Major Version Updater docs |
| .github/workflows/test-major-version-updater.yaml | Updated tag_name → tag-name, added github-token secret |
| .github/workflows/release-image.yaml | Added github-token input (check action compatibility) |
| .github/workflows/release-discussion.yaml | Switched from env GH_TOKEN to github-token input |
| .github/workflows/major-version-updater.yaml | Introduced secrets.github-token and renamed tag_name |
Comments suppressed due to low confidence (3)
.github/workflows/major-version-updater.yaml:12
- The workflow only requests
contents: readbut force-pushing tags requirescontents: write. Update permissions tocontents: writeor add write for tags.
permissions:
.github/workflows/release-image.yaml:72
- The
docker/build-push-action(or whichever action this step uses) does not accept agithub-tokeninput. Confirm the action supports this parameter or remove it to prevent workflow failures.
github-token: ${{ secrets.github-token }}
.github/workflows/release-discussion.yaml:46
- The
abirismyname/create-discussionaction expects a token viarepo-tokenorgithub_tokeninput (or viaenv.GH_TOKEN). Verify the correct parameter name, asgithub-tokenmay not be recognized.
github-token: ${{ secrets.github-token }}