Skip to content

Publish to GitHub Package Registry in publish action #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

Publish to GitHub Package Registry in publish action #71

merged 1 commit into from
Oct 3, 2022

Conversation

colebemis
Copy link
Member

The publish workflow was skipping the postpublish script that publishes this package to the GitHub Package Registry. This PR removes the --ignore-scripts flag in that workflow that was preventing the postpublish script from running

@colebemis colebemis requested a review from a team as a code owner October 3, 2022 23:03
dgreif
dgreif approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might slow the publish down a bit if it has to rebuild everything, but I think this should fix GHPR publishing 🤞

@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@colebemis colebemis merged commit 6451298 into main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgreif dgreif dgreif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colebemis @primer-css @dgreif