Skip to content

set trailing commas to all #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2022
Merged

set trailing commas to all #19

merged 1 commit into from
Dec 1, 2022

Conversation

keithamus
Copy link
Contributor

Following on from #18, this sets trailingCommas to all which is in-line with Prettier v3 (see prettier/prettier#11465)

@keithamus keithamus requested a review from a team as a code owner December 1, 2022 10:07
@keithamus keithamus requested a review from srt32 December 1, 2022 10:07
koddsson
koddsson approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@koddsson
Copy link
Contributor

koddsson commented Dec 1, 2022

https://prettier.io/docs/en/options.html#trailing-commas

@keithamus keithamus merged commit d76e806 into master Dec 1, 2022
@keithamus keithamus deleted the set-trailing-commas-to-all branch December 1, 2022 11:05
@maraisr maraisr mentioned this pull request Jun 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srt32 srt32 Awaiting requested review from srt32 srt32 is a code owner automatically assigned from github/web-systems-reviewers

1 more reviewer

@koddsson koddsson koddsson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithamus @koddsson