Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github/relative-time-element
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 265a9db
Choose a base ref
...
head repository: github/relative-time-element
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cc5096d
Choose a head ref
  • 7 commits
  • 17 files changed
  • 1 contributor

Commits on Nov 22, 2022

  1. move customElements define calls to index.js and refactor

    This moves the `customeElements.define` calls from each respective
    element and into the index.js file. This is useful for if we wish to
    load the components classes without defining the custom element.
    
    In addition, this changes the pattern of how we register the custom
    elements, to allow for HMR, as we did in
    github/catalyst#197.
    keithamus committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    a885458 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Merge pull request #209 from github/move-customelements-define-calls-…

    …to-index-js-and-refactor
    
    move customElements define calls to index.js and refactor
    keithamus authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    11b35f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    344cef3 View commit details
    Browse the repository at this point in the history
  3. remove old maintaining.md

    keithamus authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    c8cd45f View commit details
    Browse the repository at this point in the history
  4. Ensure HTMLElement exists in all contexts

    When requiring this module in NodeJS, it will error as `HTMLElement`
    does not exist. Creating a variable defaulting to `null` allows the
    class to be created in the server without causing errors. This is useful
    for introspecting the class within NodeJS.
    keithamus committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    b604b5c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #211 from github/ensure-htmlelement-exists

    Ensure HTMLElement exists in all contexts
    keithamus authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    5ff8819 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #210 from github/add-define-export-for-custom-elem…

    …ent-registration
    
    add `define` export for custom element registration
    keithamus authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    cc5096d View commit details
    Browse the repository at this point in the history
Loading