-
Notifications
You must be signed in to change notification settings - Fork 183
Comparing changes
Open a pull request
base repository: github/relative-time-element
base: 265a9db
head repository: github/relative-time-element
compare: cc5096d
- 7 commits
- 17 files changed
- 1 contributor
Commits on Nov 22, 2022
-
move customElements define calls to index.js and refactor
This moves the `customeElements.define` calls from each respective element and into the index.js file. This is useful for if we wish to load the components classes without defining the custom element. In addition, this changes the pattern of how we register the custom elements, to allow for HMR, as we did in github/catalyst#197.
Configuration menu - View commit details
-
Copy full SHA for a885458 - Browse repository at this point
Copy the full SHA a885458View commit details
Commits on Nov 23, 2022
-
Merge pull request #209 from github/move-customelements-define-calls-…
…to-index-js-and-refactor move customElements define calls to index.js and refactor
Configuration menu - View commit details
-
Copy full SHA for 11b35f5 - Browse repository at this point
Copy the full SHA 11b35f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 344cef3 - Browse repository at this point
Copy the full SHA 344cef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8cd45f - Browse repository at this point
Copy the full SHA c8cd45fView commit details -
Ensure HTMLElement exists in all contexts
When requiring this module in NodeJS, it will error as `HTMLElement` does not exist. Creating a variable defaulting to `null` allows the class to be created in the server without causing errors. This is useful for introspecting the class within NodeJS.
Configuration menu - View commit details
-
Copy full SHA for b604b5c - Browse repository at this point
Copy the full SHA b604b5cView commit details -
Merge pull request #211 from github/ensure-htmlelement-exists
Ensure HTMLElement exists in all contexts
Configuration menu - View commit details
-
Copy full SHA for 5ff8819 - Browse repository at this point
Copy the full SHA 5ff8819View commit details -
Merge pull request #210 from github/add-define-export-for-custom-elem…
…ent-registration add `define` export for custom element registration
Configuration menu - View commit details
-
Copy full SHA for cc5096d - Browse repository at this point
Copy the full SHA cc5096dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 265a9db...cc5096d