Skip to content

Format attribute does not respect lang #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brunoprietog opened this issue Nov 21, 2022 · 3 comments · Fixed by #206
Closed

Format attribute does not respect lang #205

brunoprietog opened this issue Nov 21, 2022 · 3 comments · Fixed by #206

Comments

@brunoprietog
Copy link

Hi,

If I have an html with lang="es" and I insert a relative-time element with custom format attribute, the names of the days, for example, are still in English.

Do you plan to use intl for this as well?

Thanks!
@keithamus
Copy link
Contributor

Thanks for the issue @brunoprietog. Are you using the latest version of this element? The title format uses lang since at least v3.2.0. I am unable to reproduce the issue, here is a screenshot of me hovering over an element on the example/index.html page with lang=es on the html element.

I'll close this for now as I'm unable to reproduce, but if you can provide a valid reproduction we can re-open this issue and explore some solutions!

@keithamus keithamus reopened this Nov 21, 2022
@keithamus
Copy link
Contributor

Sorry just realised I misread this and thought you were referring to the title attribute... I blame lack of caffeine. We can localise the day/month names for custom formatting for sure!

@keithamus keithamus mentioned this issue Nov 21, 2022
Merged
@brunoprietog
Copy link
Author

Thanks! That was very fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strftime localisation github/relative-time-element
2 participants
@keithamus @brunoprietog