TypeScript #15
Merged
TypeScript #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
dgraham
commented
Oct 17, 2019
| super() | ||
| this.currentQuery = null | ||
| this.debounceInputChange = debounce(() => fetchResults(this)) | ||
| this.boundFetchResults = () => fetchResults(this) |
There was a problem hiding this comment.
TypeScript's strict-property-initialization test caught these null instance variables previously assigned in the connectedCallback.
| @@ -74,7 +81,7 @@ async function fetchResults(remoteInput: RemoteInputElement, checkCurrentQuery: | |||
| let errored = false | |||
| let html = '' | |||
| try { | |||
| response = await fetch(url, { | |||
| response = await fetch(url.toString(), { | |||
There was a problem hiding this comment.
Nice catch by TypeScript where the Fetch API doesn't accept URL values.
There was a problem hiding this comment.
Interestingly, fetch does accept URL values, it just implicitly casts them to string: https://twitter.com/Keithamus/status/1185127977249574912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the Flow + Babel toolchain to TypeScript.
The original motivation was to be able to use private instance variables without using the
#syntax, but the private modifier is a compile-time only check. We need microsoft/TypeScript#30829 before we can replace our WeakMap state pattern with private fields.There is no escaping the
#syntax.