Add note about loadend -> remote-input-success #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muan
suggested changes
Oct 30, 2019
There was a problem hiding this comment.
Network events are always meant to only communicate network request status. Checking if remote-input has performed its function should always be the responsibility of its custom events.
I suggest instead of adding a note to against network events, we make it explicit that HTML would be set when remote-input-success is dispatched.
Co-Authored-By: Mu-An 慕安 <muan@github.com>
muan
approved these changes
Oct 30, 2019
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had 2 instances now where
loadendis used to change HTML based on the response fromremote-input-element.This doesn't work properly because the DOM is not updated with the response until just after
remote-input-success.To avoid this issue in the future, this adds a simple note explaining this caveat
cc @github/web-systems