Skip to content

Commit 05e8276

Browse files
issyl0issyl0
authored
config/default: Add Enabled: true cops now configured by default
- Previously these were disabled because of `DisableByDefault: true`. Since we removed that config, all of these become enabled. That's somewhat undesirable since when we ship the new version, downstream consumers of this gem will have to make decisions to enable or disable the cops. We should do this for them and make this gem the source of truth matching the styleguide as far as possible. Of course, downstream projects are free to tweak in their own `.rubocop.yml` for what matches their project style, but we should attempt to set a central standard according to the styleguide that we publish, to make writing Ruby at GitHub easier. - I left some TODOs to audit these (before we ship the new gem version!) for whether or not they: - a) already exist in the file in either enabled/disabled state; - b) checking if the GitHub Ruby styleguide has opinions on them and enabling/disabling accordingly. - This list was (as in the previous commit) generated by: ```ruby require "yaml" y = YAML.unsafe_load_file("show-cops.yml") cfg = YAML.unsafe_load_file(".rubocop.yml") on = y.keys.select { |k| y[k]["Enabled"] == true } (on - cfg.keys).sort.each { |k| puts "#{k}:\n Enabled: true\n\n" } ```
1 parent f40758f commit 05e8276

File tree

1 file changed

+1230
-0
lines changed

1 file changed

+1230
-0
lines changed

0 commit comments

Comments
 (0)