Skip to content

config/default: Stop disabling all cops by default #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

config/default: Stop disabling all cops by default #117

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f874c43
config/default: Stop disabling all cops by default
issyl0 Oct 10, 2022
87eaa0c
config/default: Remove redundant `Enabled: true` for cops
issyl0 Oct 10, 2022
638d418
Autocorrect RuboCop `Layout/EmptyLines` offenses
issyl0 Oct 10, 2022
0ca6227
Autocorrect RuboCop `Layout/SpaceInsideHashLiteralBraces` offenses
issyl0 Oct 10, 2022
f107008
Autocorrect RuboCop `Style/StringConcatenation` offenses
issyl0 Oct 10, 2022
d7ddb57
Autocorrect RuboCop `Style/IfUnlessModifier` offenses
issyl0 Oct 10, 2022
cc0a4b8
config/default: Disable some of the default rules
issyl0 Oct 10, 2022
8d8c578
Configure and autocorrect RuboCop `Style/PercentLiteralDelimiters`
issyl0 Oct 10, 2022
5241eb0
Autocorrect RuboCop `Style/RedundantParentheses` offenses
issyl0 Oct 10, 2022
89ac526
config/default: Disable more rules
issyl0 Oct 10, 2022
51aa7fb
Autocorrect RuboCop \`Style/SafeNavigation\` offenses
issyl0 Oct 10, 2022
401c927
Autocorrect RuboCop `Layout/SpaceAroundOperators` offenses
issyl0 Oct 10, 2022
5ba9ba8
config/default: Disable more rules that the styleguide doesn't opine on
issyl0 Oct 10, 2022
127c051
Autocorrect RuboCop `Layout/EmptyLineAfterGuardClause` offenses
issyl0 Oct 10, 2022
30fe0a5
Autocorrect RuboCop `Layout/RedundantLineBreak` offenses
issyl0 Oct 10, 2022
be167bb
Fix RuboCop `Naming/MemoizedInstanceVariableName` offenses
issyl0 Oct 10, 2022
9b62169
Autocorrect RuboCop `Style/MultipleComparison` offenses
issyl0 Oct 10, 2022
2672610
Autocorrect RuboCop `Style/{RedundantFreeze,MutableConstants}` offenses
issyl0 Oct 10, 2022
a53163c
Fix RuboCop `Lint/UselessAssignment` offenses
issyl0 Oct 10, 2022
1557c29
config/default: Disable `Lint/AssignmentInCondition` with a big TODO
issyl0 Oct 10, 2022
816ca3a
Merge branch 'master' into rubocop-enabled-by-default
issyl0 Oct 10, 2022
e2b3734
config/default: Unset `EnabledByDefault: true`
issyl0 Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix RuboCop Naming/MemoizedInstanceVariableName offenses
  • Loading branch information
@issyl0
issyl0 authored Oct 10, 2022
commit be167bbb495b93be73326865db87d77a0598e66c
2 changes: 1 addition & 1 deletion lib/rubocop/cop/github/insecure_hash_algorithm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def just_encoding?(val)
DEFAULT_ALLOWED = %w(SHA256 SHA384 SHA512).freeze

def allowed_hash_functions
@allowed_algorithms ||= cop_config.fetch("Allowed", DEFAULT_ALLOWED).map(&:downcase)
@allowed_hash_functions ||= cop_config.fetch("Allowed", DEFAULT_ALLOWED).map(&:downcase)
end

def alg_name(val)
Expand Down