Skip to content

Update codeowners, dependencies and build config to fix Dependabot PRs #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

bensheldon
Copy link
Contributor

@bensheldon bensheldon commented Mar 24, 2023

  • ran bundle update
  • Add Ruby 3.2 to test matrix
  • Add .ruby-version
  • Update Bundler version and include ruby platform in lockfile
  • Ensure Rubocop::Config is passed to test helper
  • Update codeowners to rubocop-reviewers team

I didn't update any of the actual dependencies (e.g. rubocop, minitest, activesupport, etc.)

I did update the dependencies. Rubocop now returns all of the new cops that could be enabled/disabled. I think this is fine to leave as-is because updating the Gemfile.lock in this gem won't affect any applications that bundle this gem (I didn't update any of the gemspec constraints).

@bensheldon bensheldon requested a review from a team as a code owner March 24, 2023 17:09
@bensheldon bensheldon changed the title Update dependencies and build config to fix Dependabot PRs Update codeowners, dependencies and build config to fix Dependabot PRs Mar 24, 2023
@composerinteralia
Copy link
Member

Screen Shot 2023-03-24 at 1 24 22 PM

@composerinteralia
Copy link
Member

nvm, fixed it

@bensheldon bensheldon merged commit 70b9479 into main Mar 24, 2023
@bensheldon bensheldon deleted the bundle-updates branch March 24, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants