Skip to content

Suggestions for PR #1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2022
Merged

Suggestions for PR #1 #2

merged 3 commits into from
Aug 24, 2022

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Aug 22, 2022 •
edited
Loading

A few suggestions!

  • Add vendor to .gitignore. This will make sure that vendor doesn't get checked in so we can keep this repo small.
  • Move all gem dependencies configurations from Gemfile to gemspec file.
  • In rubocop.yml, we'll configure to use recommended setup in rubocop-github. This PR checks in result of running bundle exec rubocop -a to autocorrect errors.
  • Bump required Ruby version to 2.7. I think it's fine to bump up since 2.6 is a bit older.

@khiga8 khiga8 requested a review from bolonio August 22, 2022 22:56
@bolonio bolonio merged commit 5c9cd89 into rubocop-rules-set Aug 24, 2022
@bolonio bolonio deleted the kh-suggestions branch August 24, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bolonio bolonio bolonio approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khiga8 @bolonio