Skip to content

Handle different schemes in dedup logic #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

srt32
Copy link
Member

@srt32 srt32 commented Jun 1, 2022

closes #317

All PRs:

  • Has tests
  • Documentation updated - should anything be updated?

Adding a new header

Generally, adding a new header is always OK.

  • Is the header supported by any user agent? If so, which?
  • What does it do?
  • What are the valid values for the header?
  • Where does the specification live?

Adding a new CSP directive

  • Is the directive supported by any user agent? If so, which?
  • What does it do?
  • What are the valid values for the directive?

Some questions

  • Does this change follow the spec?
  • Is URI.parse okay? Could it raise? Is there a more performant way to do this?

@srt32
Copy link
Member Author

srt32 commented Jun 1, 2022

#478 beat me to it!

@srt32 srt32 closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Deduplication Doesn't Take Schemes into Account
1 participant