Skip to content

Semantically parse source expressions. #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from

Conversation

lgarron
Copy link
Contributor

@lgarron lgarron commented Aug 17, 2022

Recently, we've had a spate of fixes for parsing directives and source-expressions, stemming from the fact that the code doesn't understand the format of valid expressions, and makes local assumptions about what they look like — in particular, assuming a resemblance to URLs during deduplication.

#490
#478

This PR is an attempt to 'bite the bullet" and parse source expressions so we can semantically deduplicate matching URLs.

All PRs:

  • Has tests
  • Documentation updated (N/A)

Adding a new header

@lgarron lgarron requested review from vcsjones and JackMc August 17, 2022 19:04
@lgarron lgarron closed this Aug 17, 2022
@lgarron lgarron deleted the lgarron/parse-source-expressions branch August 17, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants