-
Notifications
You must be signed in to change notification settings - Fork 253
[Java] CWE-552: Query to detect configuration file/source code exposure from unsafe request dispatcher #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @luchua-bc Thanks for the contribution and sorry for the radio silence as you commented on github/codeql#6251 (comment) I think its better to close this PR and then open a new one when @haby0 one gets merged. Is that ok with you? if so, please close this PR. |
@pwntester Thanks for the suggestion. The @haby0 one hasn't received any update for two months therefore it took much longer than I originally thought. I"m OK with closing this one for the time being. |
Your submission is now in status Closed. For information, the evaluation workflow is the following: |
@pwntester I think he can open this pr, right? @luchua-bc |
@luchua-bc better create a new PR for it |
As per the advice of @pwntester, I've submitted a new PR #7286 to replace this one with a new issue #495 |
Query
Link to pull request with your CodeQL query:
Relevant PR: github/codeql#6251
CVE ID(s)
List the CVE ID(s) associated with this vulnerability. GitHub will automatically link CVE IDs to the GitHub Advisory Database.
Report
Describe the vulnerability. Provide any information you think will help GitHub assess the impact your query has on the open source community.
Directly incorporating user input into HTTP requests dispatched from the Java EE
RequestDispatcher
without validating the input can allow any web application resource such as configuration files and source code to be disclosed.As stated in the Java API doc, when using a Java EE
RequestDispatcher
, requests may be dispatched to any part of the web application bypassing both implicit (no direct access to WEB-INF or META-INF) and explicit (defined by the web application) security constraints. Unsanitized user provided data must not be used to construct the path passed to theRequestDispatcher
as it is very likely to create a security vulnerability in the application.This query detects unsafe invocations of RequestDispatcher with user controlled input.
Result(s)
Provide at least one useful result found by your query, on some revision of a real project.
The text was updated successfully, but these errors were encountered: