Skip to content

chore: add major version updater workflow back #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2025

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 4, 2025

Related to #272

Accidentally removed during previous cleanup

We're going to use actions/release-action since it simplifies some things and already have example from actions/stale usage

  • Centralize checkov checks to skip in linters/.checkov.yml
    • CKV_GHA_7 was failing for this new action, it is invalid
    • CKV_DOCKER_2, CKV_DOCKER_3 were on the Dockerfil previously

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

Accidentally removed during previous cleanup

We're going to use actions/release-action since it simplifies some things
and already have example from actions/stale usage

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Apr 4, 2025
@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 04:17
@jmeridth jmeridth requested a review from a team as a code owner April 4, 2025 04:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request reintroduces a workflow to update the major version tag on release, ensuring consistency with prior behavior while leveraging GitHub Actions for automation.

  • Added a new workflow triggered on release events and manual dispatch.
  • Configures the environment to derive the tag name dynamically and update the tag using a GitHub Action.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@jmeridth
Copy link
Member Author

jmeridth commented Apr 4, 2025

Once this merges, going to run the workflow manually against v2.3.0 tag and see if it creates the v2 tag pointed at the same SHA.

jmeridth added 3 commits April 3, 2025 23:22
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth merged commit 5e0322a into main Apr 4, 2025
32 checks passed
@jmeridth jmeridth deleted the jm_reintroduce_major_version_updater_workflow branch April 4, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant