fix: output of printed repo url does not work #317
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the repository to improve URL formatting in log messages, update version references in the README, and rename the default issue title for better CLI search accuracy.
- Fixed the output in stale_repos.py by removing an extra colon from the printed URL.
- Upgraded GitHub Action versions and updated the default issue title format in the README.md file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| stale_repos.py | Removed an unintended colon from the printed URL in the repo data. |
| README.md | Updated action versions and changed the default issue title format. |
| @@ -386,7 +386,7 @@ def set_repo_data( | |||
| Potentially caused by ghost user." | |||
| ) | |||
|
|
|||
| print(f"{repo.html_url}: {days_inactive} days inactive") # type: ignore | |||
| print(f"{repo.html_url} {days_inactive} days inactive") # type: ignore | |||
There was a problem hiding this comment.
[nitpick] While removing the colon fixes the URL link issue, the new formatting could reduce clarity in separating the URL from the inactive days. Consider using a different delimiter (e.g., a comma or tab) to improve readability while keeping the URL valid.
| print(f"{repo.html_url} {days_inactive} days inactive") # type: ignore | |
| print(f"{repo.html_url},{days_inactive} days inactive") # type: ignore |
Copilot uses AI. Check for mistakes.
|
@chrheg thank you for the contribution. got some test failures. Thank you for updating the readme. The issue rename is a nice catch and the colon also. Will look again once tests fixed. |
|
Thanks for the changes!! I'm thinking that these might need to be considered breaking changes with the report name change. Any automation people might have to operate on the output file could break with a name update. @jmeridth do you agree with rolling the major version here? |
Updated the test file now 👍 Hopefully it passes 🤞 |
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking