This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Corrects code that would fail due to type mismatch #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know this probably seems nit-picky since this isn't a language reference, but it seems numberOfWheels should be converted to Float when doing the math here to get tire pressure. Otherwise, I'm loving this style guide!
|
Good call: code samples should compile if at all possible. I think this was written back in the days when Swift did type conversion, and never got updated. |
robrix
added a commit
that referenced
this pull request
Jun 4, 2015
Corrects code that would fail due to type mismatch
niwatako
pushed a commit
to niwatako/swift-style-guide
that referenced
this pull request
Mar 31, 2016
Corrects code that would fail due to type mismatch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this probably seems nit-picky since this isn't a language reference, but it seems
numberOfWheelsshould be converted toFloatwhen doing the math here to get tire pressure. Otherwise, I'm loving this style guide!