Skip to content

No role or aria on slot element #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 29, 2024
Merged

No role or aria on slot element #83

merged 4 commits into from
Feb 29, 2024

Conversation

owenniblock
Copy link
Member

@owenniblock owenniblock commented Feb 29, 2024

Motivation

So it turns out that the slot element should not have a role or aria.

This change makes it so that we add the tablist as the parent of the slot.

@owenniblock owenniblock requested a review from a team as a code owner February 29, 2024 11:03
@owenniblock owenniblock merged commit 3996e61 into main Feb 29, 2024
@owenniblock owenniblock deleted the no-role-on-slot branch February 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants