Skip to content

Register event types for better type inference #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

Register event types for better type inference #89

merged 1 commit into from
Mar 12, 2024

Conversation

stof
Copy link
Contributor

@stof stof commented Mar 12, 2024

This allows typescript to know which kind of event object is passed to listeners for those event names.

@stof
Register event types for better type inference
75d656a 
This allows typescript to know which kind of event object is passed to listeners for those event names.
@stof stof requested a review from a team as a code owner March 12, 2024 17:58
camertron
camertron approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@camertron camertron merged commit 22b1f80 into github:main Mar 12, 2024
@camertron
Copy link
Contributor

Released in v4.5.0 🎉

@stof stof deleted the patch-1 branch March 13, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stof @camertron