Skip to content

Install eslint-plugin-custom-elements #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2021
Merged

Install eslint-plugin-custom-elements #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1048702
Run `npm audit fix`
koddsson Apr 30, 2021
765e644
Install `eslint-plugin-custom-elements`
koddsson Apr 30, 2021
6cad200
Update eslint
koddsson Apr 30, 2021
b2e891f
Enable `eslint-plugin-custom-elements`
koddsson Apr 30, 2021
dcf2f80
Combine index and task-lists-element files
koddsson Apr 30, 2021
a035591
Ignore some eslint rules
koddsson Apr 30, 2021
6270102
Use node14 in CI
koddsson Apr 30, 2021
f628121
empty commit to trigger CI
koddsson Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
{
"root": true,
"plugins": ["custom-elements"],
"globals": {
"TaskListsElement": "readonly"
},
"extends": [
"plugin:github/recommended",
"plugin:github/browser",
"plugin:github/typescript"
]
"plugin:github/typescript",
"plugin:custom-elements/recommended"
],
"rules": {
"custom-elements/tag-name-matches-class": ["error", {"suffix": "Element"}]
}
}
4 changes: 2 additions & 2 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 12.x
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 12.x
node-version: 14.x
- name: npm install, build, and test
run: |
npm install
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import '@github/task-lists-element'
With a script tag:

```html
<script type="module" src="./node_modules/@github/task-lists-element/dist/index.js">
<script type="module" src="./node_modules/@github/task-lists-element/dist/task-lists-element.js">
```

### Markup
Expand Down
136 changes: 68 additions & 68 deletions examples/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,74 +1,74 @@
<!doctype html>
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<!-- <script type="module" src="../dist/index.js"></script> -->
<script type="module" src="https://unpkg.com/@github/task-lists-element@latest"></script>
<title>task-lists-element demo</title>
</head>
<body>
<task-lists sortable>
<ul class="contains-task-list">
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox">
Hubot
</label>
</li>
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox">
Bender
</label>
</li>
</ul>
<head>
<meta charset="utf-8" />
<!-- <script type="module" src="../dist/task-lists-element.js"></script> -->
<script type="module" src="https://unpkg.com/@github/task-lists-element@latest"></script>
<title>task-lists-element demo</title>
</head>
<body>
<task-lists sortable>
<ul class="contains-task-list">
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox" />
Hubot
</label>
</li>
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox" />
Bender
</label>
</li>
</ul>

<ul>
<li>
Nested
<ul>
<li>
Nested

<ul class="contains-task-list">
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox">
WALL-E
</label>
</li>
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox">
R2-D2
</label>
<ul class="contains-task-list">
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox" />
WALL-E
</label>
</li>
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox" />
R2-D2
</label>

<ul class="contains-task-list">
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox">
Baymax
</label>
</li>
</ul>
</li>
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox">
BB-8
</label>
</li>
</ul>
</li>
</ul>
</task-lists>
<pre class="events"></pre>
<script type="text/javascript">
const events = document.querySelector('.events')
document.addEventListener('task-lists-check', function(event) {
events.append(`task-lists-check - checked: ${event.detail.checked}, position: ${event.detail.position}\n`)
})
<ul class="contains-task-list">
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox" />
Baymax
</label>
</li>
</ul>
</li>
<li class="task-list-item">
<label>
<input type="checkbox" class="task-list-item-checkbox" />
BB-8
</label>
</li>
</ul>
</li>
</ul>
</task-lists>
<pre class="events"></pre>
<script type="text/javascript">
const events = document.querySelector('.events')
document.addEventListener('task-lists-check', function (event) {
events.append(`task-lists-check - checked: ${event.detail.checked}, position: ${event.detail.position}\n`)
})

document.addEventListener('task-lists-move', function(event) {
events.append(`task-lists-move - from: ${event.detail.src}, to: ${event.detail.dst}\n`)
})
</script>
</body>
document.addEventListener('task-lists-move', function (event) {
events.append(`task-lists-move - from: ${event.detail.src}, to: ${event.detail.dst}\n`)
})
</script>
</body>
</html>
Loading