Skip to content

Fix ESLint violation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021
Merged

Fix ESLint violation #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/task-lists-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@ import {SortEndArgs, isDragging, sortable} from './sortable'
const observers = new WeakMap()

export default class TaskListsElement extends HTMLElement {
// eslint-disable-next-line custom-elements/no-constructor
constructor() {
super()

connectedCallback(): void {
this.addEventListener('change', (event: Event) => {
const checkbox = event.target
if (!(checkbox instanceof HTMLInputElement)) return
Expand All @@ -23,14 +20,10 @@ export default class TaskListsElement extends HTMLElement {
)
})

observers.set(this, new MutationObserver(syncState.bind(null, this)))
}
const observer = new MutationObserver(syncState.bind(null, this))
observers.set(this, observer)

connectedCallback(): void {
const observer = observers.get(this)
if (observer) {
observer.observe(this, {childList: true, subtree: true})
}
observer.observe(this, {childList: true, subtree: true})
syncState(this)
}

Expand Down