Fix: Compute the task list item index correctly. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
reviewed
Jul 29, 2021
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
|
@koddsson Could you please review again? |
|
@github/web-systems-reviewers I would appreciate if you could review this PR. |
|
Sorry, this wasn't showing up in the first responder queue because the reviewer's team wasn't requested. It is now, but I'll take this on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Problem
If a task list contained elements other than task list items (for example
<a>) then the position of the checked/unchecke task list item was being calculated incorrectly.Fix
The position of a task list item should be computed using only other task list items (and ignoring any other elements).