-
Notifications
You must be signed in to change notification settings - Fork 28
Space being unavoidably added #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the issue! PRs welcome to add the optionality. |
How do you feel about removing it and pushing v3.0.0 with it? I think the proper fix is to remove it instead of working around the issue with an option. |
We’d like to retain the behaviour so if you think it’s undesirable for your usecase, then we can make it an option (eg a suffix attribute which defaults to a space) |
My use case might be something for GitHub to consider too:
A HTML attribute will not work as I need different behaviour per-key, so it needs to be an option that is set before |
Actually, a HTML option will work as well when set to the empty string as the optional space can be appended during the |
There is an unavoidable space character being appended target element's
value
during thetext-expander-value
event:text-expander-element/src/text-expander-element.ts
Line 128 in 5b5f7ad
Could this be removed or made optional? I think the consumer of the module should be in control of whether they want this space, or not.
The text was updated successfully, but these errors were encountered: