Fix: dispatching change event after new value is set. #27
Conversation
| @@ -129,6 +129,8 @@ class TextExpander { | |||
|
|
|||
| this.input.value = beginning + value + remaining | |||
|
|
|||
| this.input.dispatchEvent(new Event('change', {bubbles: true})) | |||
There was a problem hiding this comment.
Can we please add a test that confirms this behaviour, that we can also use to validate and avoid regressions here.
There was a problem hiding this comment.
@keithamus , I don't have experience in testing. can you please help me out here?
There was a problem hiding this comment.
@keithamus, I have added some tests by looking at previous tests.
|
@keithamus , please review this PR. |
There was a problem hiding this comment.
Hey @Sachin-chaurasiya; the tests run fine for me when I remove the line that dispatches the change event.
Maybe you can add motivation for this change to the PR and double-check that this change event is being dispatched already by the browser.
| @@ -129,6 +129,8 @@ class TextExpander { | |||
|
|
|||
| this.input.value = beginning + value + remaining | |||
|
|
|||
| this.input.dispatchEvent(new Event('change', {bubbles: true})) | |||
There was a problem hiding this comment.
The tests run green for me with this line removed so either the tests are wrong or the implementation.
|
Closing this PR as an Issue is different. |
@keithamus, Please review the PR.