Skip to content

Improve and export types #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 29, 2025
Merged

Improve and export types #72

merged 4 commits into from
Jan 29, 2025

Conversation

silverwind
Copy link
Contributor

  • Export existing types with TextExpander prefix. This is not breaking because previous unprefixed types were not being exported.
  • Add and export type for TextExpanderChangeEvent

@silverwind silverwind requested a review from a team as a code owner January 26, 2025 13:32
@silverwind silverwind mentioned this pull request Jan 26, 2025
Merged
wxiaoguang
wxiaoguang reviewed Jan 26, 2025
View reviewed changes
@silverwind silverwind changed the title Improve types Improve and export types Jan 26, 2025
keithamus
keithamus approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshblack joshblack merged commit 4a8fe03 into github:main Jan 29, 2025
1 check passed
@silverwind silverwind deleted the types branch January 29, 2025 19:21
@silverwind
Copy link
Contributor Author

silverwind commented Jan 29, 2025 •
edited
Loading

Trying to make use of these types, I see there is the problem that index.d.ts does not export them, so instead of importing from @github/text-expander-element, one has to import from @github/text-expander-element/dist/text-expander-element.d.ts. Maybe I will send another PR to fix that later.

This was referenced Jan 29, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

+2 more reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @keithamus @wxiaoguang @joshblack