Skip to content

Hang on pretty print of options in 1.15.0-rc #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kujenga opened this issue Aug 15, 2018 · 2 comments
Closed

Hang on pretty print of options in 1.15.0-rc #668

kujenga opened this issue Aug 15, 2018 · 2 comments

Comments

@kujenga
Copy link

kujenga commented Aug 15, 2018 •
edited
Loading

I just tried out the latest release candidate, and it seems to hang when pretty printing the options. I run the program and it just sits there, seemingly doing nothing.

When I comment out this line, which the stacktrace points to, the program continues as expected for me:

github-changelog-generator/lib/github_changelog_generator/options.rb

Line 99 in 72452a1

pp(censored_values)

This is the stacktrace pointed out when I invoke Ctrl+C:

Using these options:
^CTraceback (most recent call last):
	12: from /usr/local/bin/github_changelog_generator:23:in `<main>'
	11: from /usr/local/bin/github_changelog_generator:23:in `load'
	10: from /usr/local/lib/ruby/gems/2.5.0/gems/github_changelog_generator-1.15.0.pre.rc/bin/github_changelog_generator:5:in `<top (required)>'
	 9: from /usr/local/lib/ruby/gems/2.5.0/gems/github_changelog_generator-1.15.0.pre.rc/bin/github_changelog_generator:5:in `new'
	 8: from /usr/local/lib/ruby/gems/2.5.0/gems/github_changelog_generator-1.15.0.pre.rc/lib/github_changelog_generator.rb:28:in `initialize'
	 7: from /usr/local/lib/ruby/gems/2.5.0/gems/github_changelog_generator-1.15.0.pre.rc/lib/github_changelog_generator/parser.rb:29:in `parse_options'
	 6: from /usr/local/lib/ruby/gems/2.5.0/gems/github_changelog_generator-1.15.0.pre.rc/lib/github_changelog_generator/options.rb:99:in `print_options'
	 5: from <internal:prelude>:149:in `pp'
	 4: from /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/delegate.rb:85:in `method_missing'
	 3: from /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/delegate.rb:85:in `call'
	 2: from /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'
	 1: from /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/delegate.rb:85:in `method_missing'
/usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/delegate.rb:85:in `call': Interrupt

The version I have locally:

$ github_changelog_generator --version
Version: 1.15.0-rc
@kujenga
Copy link
Author

kujenga commented Aug 15, 2018

This may be a duplicate of #663

@mob-sakai mob-sakai mentioned this issue Sep 19, 2018
Merged
@galaxylegand
Copy link

galaxylegand commented Nov 1, 2018 via email

@takke takke mentioned this issue Dec 14, 2018
Merged
@m-tmatma m-tmatma mentioned this issue Dec 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kujenga @galaxylegand