-
-
Notifications
You must be signed in to change notification settings - Fork 849
Add --base option #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --base option #258
Conversation
It would be nice if you also add description from this PR body to
|
just kind proposal: Can you add basic tests for this option? (only if you know how, and it's not burden you) |
Right, I will check these. I'm actually wondering if |
As for the tests, are you thinking of adding a fixture for that, or just mocking |
I believe fixture would be better ( in manner as it implemented for change About auto detection of the end manual change log - you just read my minds! Here`s some ideas that comes to my head about this:
And thanks again for getting move this project forward! 🍻 |
I'll have a look at these tomorrow then. |
Added an entry in README.md and automatic support for HISTORY.md |
@raphink Great addition, thanks again! ! Please, check the failed tests in last commit. |
I'll try to review that. Are you OK with the implementation? |
Yes, implementation seems good! |
Fixed the tests |
Awesome work! Thank you, @raphink! |
@raphink I found, that some guys also using
I'm not sure, that we have to do something with it, since it can be easily solved by manually specify Example:
|
@raphink another thing about If you run
it gets list of all issues under |
You mean people use Unreleased as the top entry in HISTORY.md? |
@raphink Yes. You can try, how it works on real repo:
|
So what should be expected then?
|
The additional sections is not main problem - it could be fixed easily with |
I guess it's just not a good idea to use incremental and unreleased together. Incremental with releases should work well, though. |
@raphink What you mean under "Incremental" term? |
I mean using an already generated changelog as a base for a new one, so only new tags are generated. |
For projects migrating to an automatically generated CHANGELOG, it is useful to keep the old changes in a base file that is appended, so this can be used like this (considering the migration happened after tag 0.1.15):
where CHANGELOG.base.md contains changes up to the 0.1.15 tag.
Note:
--since-tag
is implemented in #257