Skip to content

Do not alter pull_requests while iterating on it #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2015
Merged

Do not alter pull_requests while iterating on it #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/github_changelog_generator/generator/generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,22 +120,22 @@ def parse_by_sections(issues, pull_requests)
issues_a.push dict unless added
end

added_pull_requests = []
pull_requests.each do |dict|
added = false
dict.labels.each do |label|
if @options[:bug_labels].include? label.name
bugs_a.push dict
added = true
added_pull_requests.push dict
next
end
if @options[:enhancement_labels].include? label.name
enhancement_a.push dict
added = true
added_pull_requests.push dict
next
end
end
pull_requests.delete(dict) if added
end
added_pull_requests.each { |p| pull_requests.delete(p) }

[bugs_a, enhancement_a, issues_a]
end
Expand Down