On gem install, do not try to copy manpage files in the "extensions" step #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking of you, @jkeiser, when I made this change. Several small things could be changed back to "development dependency" status if this were merged, right? |
|
The dependencies I refer to can be found in the commits @jkeiser added to help us out. If we opt not to run the Rakefile as part of the install, it's all simpler. Here, they can be found in the history of the .gemspec: https://github.com/skywinder/github-changelog-generator/commits/master/github_changelog_generator.gemspec |
skywinder
added a commit
that referenced
this pull request
Mar 22, 2016
…ding-on-gem-install On gem install, do not try to copy manpage files in the "extensions" step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To dodge all issues with "you need git, you need Bundler, you need ..." when performing the "extensions" step in the install process, this change wants to drop that step.
Problems to solve:
What we miss out on with this change: man pages will no longer be copied to a location guessed by the Rakefile. (These man pages are not automatically updated.)