Skip to content

Abonas fixcomparingprbymergedatfield #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Abonas fixcomparingprbymergedatfield #372

wants to merge 4 commits into from

Conversation

jampunkramadhan
Copy link

@jampunkramadhan jampunkramadhan commented May 1, 2016

git log --pretty=oneline
git push origin --tags

@@ -245,6 +256,7 @@
- Add a rake task [\#260](https://github.com/skywinder/github-changelog-generator/pull/260) ([raphink](https://github.com/raphink))
- Add release\_url option [\#259](https://github.com/skywinder/github-changelog-generator/pull/259) ([raphink](https://github.com/raphink))
- Add --since-tag [\#257](https://github.com/skywinder/github-changelog-generator/pull/257) ([raphink](https://github.com/raphink))
>>>>>>> refs/remotes/skywinder/master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes could be outside the PR.

@jampunkramadhan
Copy link
Author

diff --git a/CHANGELOG.md b/CHANGELOG.md
index be8c8ff..442a000 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,16 @@

Change Log

+<<<<<<< HEAD
+## Unreleased
+
+Full Changelog
+
+Merged pull requests:
+
+- Add a rake task #260 (raphink)
+- Add release_url option #259 (raphink)
+- Add --since-tag, close #257 (raphink)
+=======

1.12.0 (2016-04-01)

Full Changelog

@@ -245,6 +256,7 @@

  • Add a rake task #260 (raphink)

  • Add release_url option #259 (raphink)

  • Add --since-tag #257 (raphink)
    +>>>>>>> refs/remotes/skywinder/master

    1.7.0 (2015-07-16)

    Full Changelog
    diff --git a/lib/github_changelog_generator/generator/generator_generation.rb b/lib/github_changelog_generator/generator/generator_generation.rb
    index b22fe40..efaa14d 100644
    --- a/lib/github_changelog_generator/generator/generator_generation.rb
    +++ b/lib/github_changelog_generator/generator/generator_generation.rb
    @@ -118,7 +118,7 @@ def generate_log_between_tags(older_tag, newer_tag)

    @return [Array] filtered issues and pull requests

    def filter_issues_for_tags(newer_tag, older_tag)

    •  filtered_pull_requests = delete_by_time(@pull_requests, :actual_date, older_tag, newer_tag)
      
    •  filtered_pull_requests = delete_by_time(@pull_requests, :merged_at, older_tag, newer_tag)
      

      filtered_issues = delete_by_time(@issues, :actual_date, older_tag, newer_tag)

      newer_tag_name = newer_tag.nil? ? nil : newer_tag["name"]

@jampunkramadhan jampunkramadhan deleted the abonas-fixComparingPRByMergedAtField branch May 1, 2016 16:12
@jampunkramadhan jampunkramadhan restored the abonas-fixComparingPRByMergedAtField branch May 1, 2016 16:12
@olleolleolle
Copy link
Collaborator

I'll close this - looks like robot spam.

@jampunkramadhan jampunkramadhan deleted the abonas-fixComparingPRByMergedAtField branch May 1, 2016 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants