Skip to content

Remove --between-tags option #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Lucashuang0802
Copy link
Contributor

No description provided.

@Lucashuang0802
Copy link
Contributor Author

Lucashuang0802 commented May 22, 2017

@olleolleolle I bet you are interested in collaborating with me on this one? 😃

@olleolleolle
Copy link
Collaborator

Hello!

The metadata of a change is quite important to this project.

A description which explains how something is wrong and what has been done to right it and why this all matters to a user. That's part of communicating your intent to others who wonder.

Can you find and link to any discussion which weighs the issue somewhere?

I'm sure there's context to this somewhere, but I can't find it from this PR.

@Lucashuang0802
Copy link
Contributor Author

There you go: #450 @olleolleolle

@olleolleolle olleolleolle merged commit e9ee955 into github-changelog-generator:master May 24, 2017
@olleolleolle
Copy link
Collaborator

Thank you for this PR!

@Lucashuang0802
Copy link
Contributor Author

@olleolleolle I guess there are some post-development to do for this removal. Let me see what I could find out!

@hunner
Copy link
Contributor

hunner commented Feb 20, 2018

@olleolleolle @Lucashuang0802 Is this change a bugfix or a breaking change? If the latter, then the next version of GCG will be v2.0.0 to account for this, yeah?

@hunner hunner mentioned this pull request Apr 12, 2018
@skywinder skywinder added this to the 2.0.0 milestone Apr 15, 2018
@espears4sq
Copy link

@olleolleolle @skywinder Is it possible to revert this change? It removes important functionality. By removing it, it undermines the ability of users to explain how they require enhancements to this functionality (to add even more options to specify only including updates that fall between tags).

Maybe I am misunderstanding this, but it seems it was merged with no description and no chance to solicit wider feedback. What was the purpose of this change?

You linked to the previous issue #450 but it actually seems like some people in the comments are saying that --between-tags is extremely important for them to use, and they need actually feature enhancements or better documentation, not feature removal. I don't see any evidence from #450 that this was a good candidate for removal, but perhaps I am missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants