Skip to content

Use closed_at and merged_at when filtering issues/prs #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2017
Merged

Use closed_at and merged_at when filtering issues/prs #504

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b700b84
use closed_at and merged_at when filtering issues/prs
unicolet May 16, 2017
01d7820
document use of closed_at and merged_at
unicolet May 16, 2017
1f6f4be
Merge branch 'master' of github.com:skywinder/github-changelog-genera…
unicolet Jun 6, 2017
fea84ea
Merge branch 'issue_503_wrong_tag' of github.com:unicolet/github-chan…
unicolet Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/github_changelog_generator/generator/generator_generation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,13 @@ def generate_log_between_tags(older_tag, newer_tag)
create_log_for_tag(filtered_pull_requests, filtered_issues, newer_tag, older_tag_name)
end

# Apply all filters to issues and pull requests
# Filters issues and pull requests based on, respectively, `closed_at` and `merged_at`
# timestamp fields.
#
# @return [Array] filtered issues and pull requests
def filter_issues_for_tags(newer_tag, older_tag)
filtered_pull_requests = delete_by_time(@pull_requests, "actual_date", older_tag, newer_tag)
filtered_issues = delete_by_time(@issues, "actual_date", older_tag, newer_tag)
filtered_pull_requests = delete_by_time(@pull_requests, "merged_at", older_tag, newer_tag)
filtered_issues = delete_by_time(@issues, "closed_at", older_tag, newer_tag)

newer_tag_name = newer_tag.nil? ? nil : newer_tag["name"]

Expand Down