Make 'change log' a single word #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
requested changes
Dec 13, 2017
There was a problem hiding this comment.
Thank you for making this change!
I came back to re-reading the Keepachangelog.com list of changes.
It wasn't until 1.0.0 that it embraced the changelog one-word style.
I like it.
I made a note of a change we need to be able to merge - and to have a green build.
spec/unit/octo_fetcher_spec.rb
Outdated
| @@ -265,7 +265,7 @@ | |||
| "diff_url" => "https://github.com/skywinder/changelog_test/pull/21.diff", | |||
| "patch_url" => "https://github.com/skywinder/changelog_test/pull/21.patch" }, | |||
| "body" => | |||
| "to test https://github.com/skywinder/github-changelog-generator/pull/305\r\nshould appear in change log with #20" } | |||
| "to test https://github.com/skywinder/github-changelog-generator/pull/305\r\nshould appear in changelog with #20" } | |||
There was a problem hiding this comment.
Undo the changes in this file.
They refer to data in another repository, the changing of which is outside the scope of this find-and-replace PR.
spec/unit/octo_fetcher_spec.rb
Outdated
| @@ -265,7 +265,7 @@ | |||
| "diff_url" => "https://github.com/skywinder/changelog_test/pull/21.diff", | |||
| "patch_url" => "https://github.com/skywinder/changelog_test/pull/21.patch" }, | |||
| "body" => | |||
| "to test https://github.com/skywinder/github-changelog-generator/pull/305\r\nshould appear in changelog with #20" } | |||
| "to test https://github.com/skywinder/github-changelog-generator/pull/305\r\nshould appear in change log with #20" } | |||
There was a problem hiding this comment.
The "title" (in this document, too)
"title" => "Merged br (should appear in changelog with #20)",
needs to go back to what it was before.
There was a problem hiding this comment.
Yes, just saw this.
olleolleolle
approved these changes
Dec 13, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically replaces
change logwithchangelogacross all files.There were inconsistencies in various files regarding the use of
change logandchangelog. I thinkchangelogis the correct way to write it.