Raise error instead of unhelpful behavior for --since-tag or --due-tag #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes github-changelog-generator#604 The --since-tag and --due-tag arguments exist to specify tags between which the changelog should be generated. Prior to this change if these tags do not exist then GCG continues to generate the entire changelog which is not what the user requested. This change causes an error informing the user that their specified tags do not exist so their request could not be completed. Other arguments with similar behavior such as --exclude-tags and --exclude-tags-regex may continue to only give a warning in case the user made a mistake, but should not error as nonexistent tags are trivially excluded.
olleolleolle
approved these changes
Feb 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604
The --since-tag and --due-tag arguments exist to specify tags between
which the changelog should be generated. Prior to this change if these
tags do not exist then GCG continues to generate the entire changelog
which is not what the user requested. This change causes an error
informing the user that their specified tags do not exist so their
request could not be completed.
Other arguments with similar behavior such as --exclude-tags and
--exclude-tags-regex may continue to only give a warning in case the
user made a mistake, but should not error as nonexistent tags are
trivially excluded.