Skip to content

Raise error instead of unhelpful behavior for --since-tag or --due-tag #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hunner
Copy link
Contributor

@hunner hunner commented Feb 16, 2018

Fixes #604

The --since-tag and --due-tag arguments exist to specify tags between
which the changelog should be generated. Prior to this change if these
tags do not exist then GCG continues to generate the entire changelog
which is not what the user requested. This change causes an error
informing the user that their specified tags do not exist so their
request could not be completed.

Other arguments with similar behavior such as --exclude-tags and
--exclude-tags-regex may continue to only give a warning in case the
user made a mistake, but should not error as nonexistent tags are
trivially excluded.

Fixes github-changelog-generator#604

The --since-tag and --due-tag arguments exist to specify tags between
which the changelog should be generated. Prior to this change if these
tags do not exist then GCG continues to generate the entire changelog
which is not what the user requested. This change causes an error
informing the user that their specified tags do not exist so their
request could not be completed.

Other arguments with similar behavior such as --exclude-tags and
--exclude-tags-regex may continue to only give a warning in case the
user made a mistake, but should not error as nonexistent tags are
trivially excluded.
Copy link
Collaborator

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clear and direct improvement - well explained in the description of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants