-
-
Notifications
You must be signed in to change notification settings - Fork 849
Issue #558 Keepachangelog labels #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
olleolleolle
merged 15 commits into
github-changelog-generator:master
from
jennyknuth:keepachangelog-labels
Apr 1, 2018
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5c1b350
add deprecated, removed, and security _labels and _prefixes
2341e3e
add quote
2ca2592
alphabetize options list
7cfa7ba
standardize order: enhancement, bug, breaking, deprecated, removed, s…
14d6873
standardize order, update results with new sections
dadce09
remove added irregular options
75ef80a
order sections in hierarchy
7193354
update tests to match heirarchy order
829da33
standardize on breaking first
3ebc9ca
breaking first in opts too
2ba7647
update parser with breaking first
e8cbd7a
update README
8f9083c
standardize and put breaking as first label
c80834a
correct order of breaking_labels in options
3903762
commit spec file
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,8 +66,10 @@ def extract_pair(line) | |
[key.tr("-", "_").to_sym, value.gsub(/[\n\r]+/, "")] | ||
end | ||
|
||
KNOWN_ARRAY_KEYS = %i[exclude_labels include_labels bug_labels | ||
enhancement_labels breaking_labels issue_line_labels between_tags exclude_tags] | ||
KNOWN_ARRAY_KEYS = %i[exclude_labels include_labels | ||
breaking_labels enhancement_labels bug_labels | ||
deprecated_labels removed_labels security_labels | ||
issue_line_labels between_tags exclude_tags] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tiny thing: thanks for keeping the lines short - Github diffs are rendered much better when the lines are shorter (~ 80 chars). Kudos! |
||
KNOWN_INTEGER_KEYS = [:max_issues] | ||
|
||
def convert_value(value, option_name) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording is clearer, and teaches what this is about way better.