Sort issues by detected actual_date instead of closed_at #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
olleolleolle
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #638
#504 changed issue sorting from using
closed_attime (the time the user closed the issue) to useactual_date(the time of the fix commit reference). #504 was trying to fix PR merge time tag detection (fixed in #619), but the same behavior detection does not apply to issues.Probably an improved solution to just taking the
actual_datewould be to detect the tag commit of the given sha too, similar to how PRs are sorted. But in my testing this seems to be enough for my use case so far.Also maybe offer a "Fixed commit: " options similar to the "Rebased commit: " ability. Or maybe the milestone functionality could get around it?