Skip to content

Add no-http-cache option to rake task #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcelicalderon
Copy link
Contributor

Simple change to allow to specify the http_cache option when using the rake task. This is useful as a workaround for the problem described in #738 but doesn't really fix the issue. Tested locally on my project and it worked.

@ferrarimarco
Copy link
Contributor

Hi @mcelicalderon! Thanks for your contribution. Would you mind adding a test case?

Thanks!

@mcelicalderon
Copy link
Contributor Author

mcelicalderon commented Oct 7, 2019

Sure, I'll get to this as soon as possible. In fact, what would you think about having a constant with all the options available so both the task and binary can use them. That way both will always support the same options.
Maybe something like this, but would still have to look at other parts of the code:

AVAILABLE_OPTIONS = {
  user: { short: '-u', long: '--user USER', description: 'Username of the owner of target GitHub repo.' },
  project: { ... },
  token: { ... }
}.freeze

and then on the rake task we could just do

AVAILABLE_OPTIONS.keys.each do

and the parser would just use the hash to define options.

Copy link
Collaborator

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it was an oversight, and when we figure out a way to make options generally more shareable, this will go away as a problem.

@ferrarimarco ferrarimarco merged commit 3986988 into github-changelog-generator:master Apr 10, 2020
@ferrarimarco ferrarimarco self-assigned this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants